[PATCH 12/15] staging: ath6kl: Convert A_UINT8 is_amsdu and is_acl_data_frame to A_BOOL

Joe Perches joe at perches.com
Fri Jan 28 07:45:00 PST 2011


On Fri, 2011-01-28 at 14:42 +0300, Dan Carpenter wrote:
> On Thu, Jan 27, 2011 at 08:04:29PM -0800, Joe Perches wrote:
> > -                A_UINT8 is_amsdu, tid, is_acl_data_frame;
> > +                A_BOOL is_amsdu;
> > +                A_UINT8 tid;
> > +                A_BOOL is_acl_data_frame;
> 
> Just use bool for bool and u8 for u8.  It's not reasonable for everyone
> to rename basic types for every driver.  (Unless Atheros bool really is
> different from other people's bool then it would be totally reasonable).

That's a whole set of later patches.
No worries, they're coming.
At this point, doing a straight rename causes some defects.




More information about the devel mailing list