[PATCH] pohmelfs/dir.c: Remove unneeded mutex_unlock() from pohmelfs_rename()

Greg KH gregkh at suse.de
Thu Jan 20 07:52:28 PST 2011


On Thu, Jan 20, 2011 at 01:51:13PM +0300, Evgeniy Polyakov wrote:
> On Thu, Jan 20, 2011 at 12:13:44AM +0300, Alexey Khoroshilov (khoroshilov at ispras.ru) wrote:
> > I do not see any reason for the mutex_unlock(&inode->i_mutex); in
> > pohmelfs_rename().
> > 
> > 
> > Found by Linux Driver Verification project (linuxtesting.org).
> 
> Yes, that's a bug, we already unlocked i_mutex in common path and should
> not do that on error.
> 
> Thank you. Greg, please apply.
> 
> > Signed-off-by: Alexey Khoroshilov <khoroshilov at ispras.ru>
> 
> Acked-by: Evgeniy Polyakov <zbr at ioremap.net>

Great, I'll queue it up with the next round of patches.

greg k-h


More information about the devel mailing list