[PATCH] staging: brcm80211: remove assert to avoid panic on 2.6.37 kernel
Arend Van Spriel
arend at broadcom.com
Wed Jan 19 08:35:41 PST 2011
I would think so just like the suspend/resume patch from last week. Should I have put this in the patch description (as to improve for future patches)?
From: Greg KH [gregkh at suse.de]
Sent: Wednesday, January 19, 2011 5:12 PM
To: Arend Van Spriel
Cc: devel at linuxdriverproject.org
Subject: Re: [PATCH] staging: brcm80211: remove assert to avoid panic on 2.6.37 kernel
On Wed, Jan 19, 2011 at 02:19:02PM +0100, Arend van Spriel wrote:
> The driver assumed it would receive skb packets from MAC80211 which
> are not cloned. To guard this assumption an assert was placed in
> the transmit routine. As of kernel 2.6.37 it turns out MAC80211 does
> pass skb packets that are cloned. The assert is also not needed as
> it does not lead to a failure state in our driver when the packet is
> cloned. Therefore the assert can safely be removed.
Is this something that needs to get into .37 and .38 as it's causing
problems for people now?
More information about the devel