[PATCH 1/2] Make easycap_debug non-static
Mike Thomas
rmthomas at sciolus.org
Mon Jan 10 10:34:41 PST 2011
The parameter easycap_debug appears in macros JOT and JOM and therefore
needs to be visible from all source files. The easycap_ prefix should
be sufficient to avoid namespace clashes outside the module.
Signed-off-by: Mike Thomas <rmthomas at sciolus.org>
---
drivers/staging/easycap/easycap.h | 1 -
drivers/staging/easycap/easycap_main.c | 2 +-
2 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/easycap/easycap.h b/drivers/staging/easycap/easycap.h
index 8ebf96f..063d447 100644
--- a/drivers/staging/easycap/easycap.h
+++ b/drivers/staging/easycap/easycap.h
@@ -65,7 +65,6 @@
#include <linux/errno.h>
#include <linux/init.h>
#include <linux/slab.h>
-#include <linux/smp_lock.h>
#include <linux/module.h>
#include <linux/kref.h>
#include <linux/usb.h>
diff --git a/drivers/staging/easycap/easycap_main.c b/drivers/staging/easycap/easycap_main.c
index acc1f56..22cf02b 100644
--- a/drivers/staging/easycap/easycap_main.c
+++ b/drivers/staging/easycap/easycap_main.c
@@ -32,7 +32,7 @@
#include "easycap_standard.h"
#include "easycap_ioctl.h"
-static int easycap_debug;
+int easycap_debug;
static int easycap_bars;
int easycap_gain = 16;
module_param_named(debug, easycap_debug, int, S_IRUGO | S_IWUSR);
--
1.5.6.5
More information about the devel
mailing list