[staging-next 02/12] staging/easycap: prefer printk over SAY in module entry functions
gregkh at suse.de
Tue Feb 8 21:11:17 PST 2011
On Wed, Feb 09, 2011 at 07:03:22AM +0200, Winkler, Tomas wrote:
> > -----Original Message-----
> > From: Dan Carpenter [mailto:error27 at gmail.com]
> > Sent: Wednesday, February 09, 2011 1:34 AM
> > To: Winkler, Tomas
> > Cc: gregkh at suse.de; devel at linuxdriverproject.org; Mike Thomas
> > Subject: Re: [staging-next 02/12] staging/easycap: prefer printk over SAY in
> > module entry functions
> > On Wed, Feb 09, 2011 at 01:12:41AM +0200, Tomas Winkler wrote:
> > > + printk(KERN_INFO "Easycap version: "EASYCAP_DRIVER_VERSION "\n");
> > > +
> > These should just be deleted. The user can use `modinfo` if they care.
> It is very common and I think also good practices to notify user when a driver is loaded.
No, not at all. Do you really want to see this for EVERY driver your
We are removing these slowly, as it makes no sense at all. Please don't
add to it. Distros patch this kind of thing away to make for faster
boot time and cleaner load times, don't add extra work.
More information about the devel