[PATCH 4/8] staging: nvec: fix unmute of speakers
Marc Dietich
marvin24 at gmx.de
Thu Aug 25 01:32:16 PDT 2011
Hi Dan,
> On Wed, Aug 24, 2011 at 08:23:10PM +0200, Marc Dietrich wrote:
> > The ec command used was for muting, not unmuting.
> >
> > Signed-off-by: Marc Dietrich <marvin24 at gmx.de>
> > ---
> >
> > drivers/staging/nvec/nvec.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
> > index b2f03bb..0936c54 100644
> > --- a/drivers/staging/nvec/nvec.c
> > +++ b/drivers/staging/nvec/nvec.c
> > @@ -427,7 +427,7 @@ static int __devinit tegra_nvec_probe(struct
> > platform_device *pdev)
> >
> > dev_err(nvec->dev, "error adding subdevices\n");
> >
> > /* unmute speakers? */
>
> ^^^^^^^^^^^^^^^^^^^
> You could update the comment now that we know.
the correct comment (something like "enable speaker amplifier") will be updated
in the next window.
> > - nvec_write_async(nvec, "\x0d\x10\x59\x94", 4);
> > + nvec_write_async(nvec, "\x0d\x10\x59\x95", 4);
Thanks
Marc
More information about the devel
mailing list