[PATCH 01/14] staging: brcm80211: use wait queues instead of semaphores in wl_cfg80211.c
Arend van Spriel
arend at broadcom.com
Fri Aug 12 12:10:28 PDT 2011
On 08/12/2011 09:08 PM, Larry Finger wrote:
> On 08/12/2011 01:59 PM, Franky Lin wrote:
>> If you are refering to this line
>> >>> + } while ((e = brcmf_deq_event(cfg_priv)));
>>
>> The extra parentheses are added to fix a compiler warning:
>> drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c: In function
>> ‘brcmf_event_handler’:
>> drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c:3576: warning: suggest
>> parentheses around assignment used as truth value
> Does checkpatch allow that assignment in the while statement? I would expect it
> to want you to
>
> e = brcmf_deq_event(cfg_priv);
> } while (e);
>
> Larry
>
Yep. That is the v2 I sent. btw checkpatch did not complain on the
original patch.
Gr. AvS
--
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --
More information about the devel
mailing list