[PATCH 5/8] staging: vme: add functions for bridge module refcounting
manohar.vanga at cern.ch
Tue Aug 9 07:35:09 PDT 2011
> > I am not really an expert in these matters but would something like a sysfs file
> > be a cleaner approach to providing information on allocated resources within the
> > driver?
> That would probably be a better idea.
Great! We'll add a sysfs file for this :)
> > int ret = 0;
> > ...
> > vme_bridge_get(bridge);
> > if (driver->probe)
> > ret = driver->probe(vdev);
> > if (ret)
> > vme_bridge_put(bridge);
> > return ret;
> After looking at the PCI and RapidIO subsystems, I think this is probably the
> correct approach. I guess the only quiestion then is at which point is
> vme_bridge_put() called assuming the probe is successful. I guess at module
> unload time, though I haven't checked in the PCI and RapidIO code.
vme_bus_remove()? If it's incorrect, we can always change this later.
If we are agreed on this, let me know and I will make the changes and
resend the patches today.
> (Thank you for your patience)
More information about the devel