[PATCH 1/8] staging/mei: PCI device and char driver support.

Jiri Slaby jirislaby at gmail.com
Wed Apr 27 05:24:53 PDT 2011


On 04/27/2011 12:27 PM, Oren Weil wrote:
> +	dev->mem_addr = pci_iomap(pdev, 0, 0);
...
> +	iounmap(dev->mem_addr);
...
> +	if (dev->mem_addr)
> +		iounmap(dev->mem_addr);

Just what I noticed after a quick look: you shall use pci_iounmap for
pci_iomap'ped space.

regards,
-- 
js


More information about the devel mailing list