[PATCH 2/3] staging: brcm80211: making device object accessible from wlc and phy
greg at kroah.com
Mon Apr 25 16:38:11 PDT 2011
On Fri, Apr 22, 2011 at 12:46:25AM -0700, Roland Vossen wrote:
> Hi guys,
> > Yes, why would a normal driver ever mess with a "raw" kobject or struct
> > device? They would use the standard functions to properly handle this
> > type of reference counting depending on their subsystem type (hint, you
> > should be doing this from the network device structure functions...)
> The 'why' I want to mess with struct device in my driver is that the
> alternative is to include cfg80211.h in every brc80211 source file
> that does message logging, which is a form of coupling that I think is
Why? What's wrong with that? That makes total sense.
> In this alternative, I would have to use wiphy_err() and
> wiphy_err() is defined as:
> #define wiphy_err(wiphy, format, args...) \
> dev_err(&(wiphy)->dev, format, ##args)
> (ref: http://lxr.linux.no/#linux+v2.6.38/include/net/cfg80211.h#L2719).
> An alternative would be if these message logging macro's (wiphy_err()
> etc) would be moved to a separate include file.
Or you could use the standard functions that the network stack provides
More information about the devel