[PATCH 1/3] staging: batman-adv: remove useless addr_to_string()
andy.shevchenko at gmail.com
Wed Oct 20 04:27:13 PDT 2010
Sorry for that. Resend new version checked by both compilation and sparse.
On Tue, Oct 19, 2010 at 8:03 PM, Greg KH <greg at kroah.com> wrote:
> On Sat, Oct 16, 2010 at 01:11:10PM +0300, Andy Shevchenko wrote:
>> Since all *printf() methods in the kernel understand '%pM' modifier the
>> conversion to the string is useless beforehand.
>> Additionally this patch decreases batman_if structure by 20 bytes.
> And also, it breaks the build:
> drivers/staging/batman-adv/vis.c: In function ‘vis_data_read_entry’:
> drivers/staging/batman-adv/vis.c:170:38: error: ‘to’ undeclared (first use in this function)
> drivers/staging/batman-adv/vis.c:170:38: note: each undeclared identifier is reported only once for each function it appears in
> Please always test your patches :(
> I've dropped this one.
> greg k-h
With Best Regards,
More information about the devel