[patch] pohmelfs: avoid null dereference

Evgeniy Polyakov zbr at ioremap.net
Fri Jan 8 06:32:11 PST 2010


On Fri, Jan 08, 2010 at 02:51:50PM +0300, Dan Carpenter (error27 at gmail.com) wrote:
> err_out_put is for when the netfs_trans_alloc() succeeded.
> 
> Signed-off-by: Dan Carpenter <error27 at gmail.com>

Looks good, thank you.
Greg, please apply it to the appropriate tree.

> --- orig/drivers/staging/pohmelfs/inode.c	2010-01-08 09:24:14.000000000 +0300
> +++ devel/drivers/staging/pohmelfs/inode.c	2010-01-08 09:24:30.000000000 +0300
> @@ -322,7 +322,7 @@ int pohmelfs_write_create_inode(struct p
>  	t = netfs_trans_alloc(psb, err + 1, 0, 0);
>  	if (!t) {
>  		err = -ENOMEM;
> -		goto err_out_put;
> +		goto err_out_exit;
>  	}
>  	t->complete = pohmelfs_write_inode_complete;
>  	t->private = igrab(inode);

-- 
	Evgeniy Polyakov


More information about the devel mailing list