[PATCH] adsp: Fix test on unsigned in find_adsp_module_by_id()

Roel Kluin roel.kluin at gmail.com
Fri Oct 16 10:51:55 PDT 2009


A negative id will not be noticed unless the comparison is signed.

Signed-off-by: Roel Kluin <roel.kluin at gmail.com>
---
diff --git a/drivers/staging/dream/qdsp5/adsp.c b/drivers/staging/dream/qdsp5/adsp.c
index d096456..6948bdc 100644
--- a/drivers/staging/dream/qdsp5/adsp.c
+++ b/drivers/staging/dream/qdsp5/adsp.c
@@ -171,7 +171,7 @@ static struct msm_adsp_module *find_adsp_module_by_id(
 	} else {
 #if CONFIG_MSM_AMSS_VERSION >= 6350
 		id = get_module_index(id);
-		if (id < 0)
+		if ((int)id < 0)
 			return NULL;
 #endif
 		return info->id_to_module[id];


More information about the devel mailing list