[PATCH] Cleanups for: line length, printk KERN_ argument, stack frame size > 2048 (added a kmalloc/kfree), style/formatting errors, incorrect include files
gregkh at suse.de
Fri Oct 9 14:29:47 PDT 2009
On Fri, Oct 09, 2009 at 02:27:42PM -0700, Randy Dunlap wrote:
> On Fri, 9 Oct 2009 14:16:10 -0700 Greg KH wrote:
> > Try changing one thing at a time per patch please.
> > There's some bugs in here:
> > > - struct config_t dig_in_config;
> > > - struct config_t dig_out_config;
> > > - struct config_t chan_in_config;
> > > - struct config_t chan_out_config;
> > > int i;
> > > + config_data = kmalloc(sizeof(struct config_data_t), GFP_KERNEL);
> > Shouldn't that be:
> > config_data = kmalloc(sizeof(struct config_data_t)*32, GFP_KERNEL);
> The new struct already includes the s.
Ah, missed that.
But your other comment about checking the kmalloc is valid. We should
not add new calls to kmalloc that doesn't check, let's not _add_ new
errors to the code :)
Bruce, care to split this up into individual patches, each doing only
one thing, and check for the return value of this call?
More information about the devel