PRJ001: TI TMP401 driver "complete"
Hans de Goede
j.w.r.degoede at hhs.nl
Sat Nov 10 06:35:02 PST 2007
Greg KH wrote:
> On Tue, Oct 30, 2007 at 07:47:28AM +0100, Hans de Goede wrote:
>> Felipe Balbi wrote:
>>> On 10/28/07, Hans de Goede <j.w.r.degoede at hhs.nl> wrote:
>>>> Hi All,
>>>> I've thrown a couple of spare hours at writing a driver for the TI TMP401 as
>>>> I've attached the complete, but untested (no access to hardware) resulting driver.
>>>> Since I never got an answer to the following two questions:
>>>> 1) does powerconsumption matter a lot (iow battery powered?
>>>> 2) do the alert and therm pins need to be configured or is this done by
>>>> the bootloader?
>>>> I've made this a bog standard hwmon driver, so the device is put in autorun
>>>> mode (the power on reset default) and the pin configuration is left untouched.
>>>> I will gladly add support for configuring the pins and using one-shot mode to
>>>> the driver if requested.
>>> i2c drivers have changed a lot and your driver still on the old style
>>> i2c driver. If you git-whatchanged drivers/i2c/chips/tps65010.c you'll
>>> see there are 2 patches from Dave Brownell updating such i2c driver.
>>> You should follow that.
>> The old style still works too, and the company who needs the driver uses an
>> older kernel, so I've sticked with the old style on purpose. I'll do a patch to
>> change to the new style when the driver has been integrated into the mainline
>> and / or if this is a blocker during review.
> Thanks for the driver, have you submitted this to the hwmon development
> list for review from those developers yet?
I'm waiting for some feedback from the company, mainly I'm waiting to
hear if it actually works. I've several other hwmon drivers in Linus
tree, so I know the process, once I'm reasonably sure the driver is ok
I'll submit it for mainline inclusion.
More information about the devel